Skip to content

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Sep 25, 2025

Description

add environment.json to run commit hook setup + fix the lint hook (hallucination)


Summary by cubic

Adds .continue/environment.json to run npm install during setup so Husky hooks are installed, and fixes the pre-commit lint hook to run reliably.

  • New Features

    • Add .continue/environment.json with install: npm i to ensure dependencies and hooks are set up.
  • Bug Fixes

    • Pre-commit: remove --no-install from npx lint-staged to avoid failures when lint-staged isn’t locally installed.

@sestinj sestinj requested a review from a team as a code owner September 25, 2025 23:20
@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team September 25, 2025 23:20
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 25, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name=".continue/environment.json">

<violation number="1" location=".continue/environment.json:2">
Prefer npm ci over npm i for reproducible, faster installs using the existing lockfile.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@@ -0,0 +1,3 @@
{
"install": "npm i"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer npm ci over npm i for reproducible, faster installs using the existing lockfile.

Prompt for AI agents
Address the following comment on .continue/environment.json at line 2:

<comment>Prefer npm ci over npm i for reproducible, faster installs using the existing lockfile.</comment>

<file context>
@@ -0,0 +1,3 @@
+{
+  &quot;install&quot;: &quot;npm i&quot;
+}
</file context>
Fix with Cubic

@sestinj sestinj merged commit 70989ff into main Sep 25, 2025
60 checks passed
@sestinj sestinj deleted the nate/env-json branch September 25, 2025 23:30
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Sep 25, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants