Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Oct 9, 2025

Description

Open the correct hub org settings link.

resolves CON-4318

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes Hub organization settings navigation to open the correct settings page for personal accounts and organizations (Linear CON-4318).

  • Bug Fixes
    • Routes personal accounts to /settings; routes orgs to /organizations/{slug}/settings.
    • Updates the click handler to accept the full org object.

@uinstinct uinstinct requested a review from a team as a code owner October 9, 2025 12:34
@uinstinct uinstinct requested review from sestinj and removed request for a team October 9, 2025 12:34
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 9, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="gui/src/pages/config/sections/OrganizationsSection.tsx">

<violation number="1" location="gui/src/pages/config/sections/OrganizationsSection.tsx:44">
Guard against undefined `org.slug` when constructing the organization settings path to avoid generating `/organizations/undefined/settings` for orgs without a slug.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2025
@RomneyDa RomneyDa merged commit f8a13ab into continuedev:main Oct 13, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uinstinct uinstinct deleted the org-settings-link branch October 14, 2025 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants