Skip to content

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Oct 13, 2025

Summary by cubic

Initialize tool call arguments as {} and validate only by name to prevent false “Incomplete tool call” errors and dropped tool calls during streaming.

  • Bug Fixes
    • Default tool call arguments to {} in processToolCallDelta for safe incremental merges.
    • Validate tool calls by name only in processStreamingResponse, allowing partial arguments until complete.

@sestinj sestinj requested a review from a team as a code owner October 13, 2025 04:04
@sestinj sestinj requested review from tingwai and removed request for a team October 13, 2025 04:04
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 13, 2025
Copy link

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@sestinj sestinj merged commit 278a209 into main Oct 13, 2025
58 checks passed
@sestinj sestinj deleted the nate/fix-mcp-stopping branch October 13, 2025 18:32
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Oct 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant