Skip to content

perf: only update sessions instead of full user object #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

perf: only update sessions instead of full user object #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions packages/payload/src/auth/operations/refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,11 @@ export const refreshOperation = async (incomingArgs: Arguments): Promise<Result>
const parsedURL = url.parse(args.req.url!)
const isGraphQL = parsedURL.pathname === config.routes.graphQL

let user = await req.payload.db.findOne<any>({
collection: collectionConfig.slug,
req,
where: { id: { equals: args.req.user.id } },
const user = await args.req.payload.findByID({
id: args.req.user.id,
collection: args.req.user.collection,
depth: isGraphQL ? 0 : args.collection.config.auth.depth,
req: args.req,
})

const sid = args.req.user._sid
Expand All @@ -86,7 +87,7 @@ export const refreshOperation = async (incomingArgs: Arguments): Promise<Result>
throw new Forbidden(args.req.t)
}

const existingSession = user.sessions.find(({ id }: { id: number }) => id === sid)
const existingSession = user.sessions.find(({ id }) => id === sid)

const now = new Date()
const tokenExpInMs = collectionConfig.auth.tokenExpiration * 1000
Expand All @@ -96,21 +97,13 @@ export const refreshOperation = async (incomingArgs: Arguments): Promise<Result>
id: user.id,
collection: collectionConfig.slug,
data: {
...user,
sessions: removeExpiredSessions(user.sessions),
},
req,
returning: false,
})
}

user = await req.payload.findByID({
id: user.id,
collection: collectionConfig.slug,
depth: isGraphQL ? 0 : args.collection.config.auth.depth,
req: args.req,
})

if (user) {
user.collection = args.req.user.collection
user._strategy = args.req.user._strategy
Expand Down