fix: lost text and wrap logic #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XR-stb
force-pushed
the
fix/warp_text_has_space
branch
from
ce90301 to
e7b8bfa
Compare
destari
approved these changes
Oct 2, 2025
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
wrapTextToWidthfunction performs word segmentation based on spaces, some lines cannot be fully filled, which I think is not very reasonable. When viewing logs in the terminal, we need a more compact display of all log content. Moreover, due to word segmentation here, some lines may lose characters due to too many characters being inserted (both in the middle and at the end of the line).Before Fix
The timestamp on the first line was wrongly wrapped, resulting in excessive blank content on the first line and the loss of all subsequent characters starting from the second line
After Fix
Before Fix
There are extra Spaces displayed on each line, which is extremely unattractive
After Fix