Remove behavior from RangeSlider and SnapshotView control

build.gradle

@@ -1,13 +1,8 @@
 ext.java9Args = [
-        // For various usages of TraversalEngine
-        "--add-exports=javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls",
-        "--add-exports=javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls",
         // For various behaviors across controls
         "--add-exports=javafx.controls/com.sun.javafx.scene.control.behavior=org.controlsfx.controls",
         // For ReadOnlyUnbackedObservableList across files
         "--add-exports=javafx.controls/com.sun.javafx.scene.control=org.controlsfx.controls",
-        // For InputMap used in behavior classes
-        "--add-exports=javafx.controls/com.sun.javafx.scene.control.inputmap=org.controlsfx.controls",
         // For EventHandlerManager in AutoCompletionBinding
         "--add-exports=javafx.base/com.sun.javafx.event=org.controlsfx.controls",
         // For MappingChange, NonIterableChange across files

controlsfx-samples/src/main/java/org/controlsfx/samples/HelloNotificationPane.java

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2013, 2014 ControlsFX
+ * Copyright (c) 2013, 2021, ControlsFX
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -26,8 +26,6 @@
  */
 package org.controlsfx.samples;
 
-import javafx.event.ActionEvent;
-import javafx.event.EventHandler;
 import javafx.geometry.Insets;
 import javafx.scene.Node;
 import javafx.scene.control.Button;
@@ -36,7 +34,6 @@
 import javafx.scene.image.ImageView;
 import javafx.scene.layout.VBox;
 import javafx.stage.Stage;
-
 import org.controlsfx.ControlsFXSample;
 import org.controlsfx.control.NotificationPane;
 import org.controlsfx.control.action.Action;
@@ -81,13 +78,11 @@ public String getControlStylesheetURL() {
         }));
 
         Button showBtn = new Button("Show / Hide");
-        showBtn.setOnAction(new EventHandler<ActionEvent>() {
-            @Override public void handle(ActionEvent arg0) {
-                if (notificationPane.isShowing()) {
-                    notificationPane.hide();
-                } else {
-                    notificationPane.show();
-                }
+        showBtn.setOnAction(e -> {
+            if (notificationPane.isShowing()) {
+                notificationPane.hide();
+            } else {
+                notificationPane.show();
             }
         });
 
@@ -97,27 +92,15 @@ public String getControlStylesheetURL() {
 
         cbUseDarkTheme = new CheckBox("Use dark theme");
         cbUseDarkTheme.setSelected(false);
-        cbUseDarkTheme.setOnAction(new EventHandler<ActionEvent>() {
-            @Override public void handle(ActionEvent arg0) {
-                updateBar();
-            }
-        });
+        cbUseDarkTheme.setOnAction(e -> updateBar());
 
         cbHideCloseBtn = new CheckBox("Hide close button");
         cbHideCloseBtn.setSelected(false);
-        cbHideCloseBtn.setOnAction(new EventHandler<ActionEvent>() {
-            @Override public void handle(ActionEvent arg0) {
-                notificationPane.setCloseButtonVisible(!cbHideCloseBtn.isSelected());
-            }
-        });
+        cbHideCloseBtn.setOnAction(e -> notificationPane.setCloseButtonVisible(!cbHideCloseBtn.isSelected()));
 
         textField = new TextField();
         textField.setPromptText("Type text to display and press Enter");
-        textField.setOnAction(new EventHandler<ActionEvent>() {
-            @Override public void handle(ActionEvent arg0) {
-                notificationPane.show(textField.getText());
-            }
-        });
+        textField.setOnAction(e -> notificationPane.show(textField.getText()));
 
         VBox root = new VBox(10);
         root.setPadding(new Insets(50, 0, 0, 10));

controlsfx/build.gradle

@@ -88,9 +88,6 @@ javadoc {
                 "javafx.base/com.sun.javafx.event=org.controlsfx.controls",
                 "javafx.web/com.sun.webkit=org.controlsfx.controls",
                 "javafx.controls/com.sun.javafx.scene.control=org.controlsfx.controls",
-                "javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls",
-                "javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls",
-                "javafx.controls/com.sun.javafx.scene.control.inputmap=org.controlsfx.controls",
                 "javafx.controls/com.sun.javafx.scene.control.behavior=org.controlsfx.controls"
         ]
 )

controlsfx/src/main/java/impl/org/controlsfx/ImplUtils.java

@@ -26,10 +26,6 @@
  */
 package impl.org.controlsfx;
 
-import java.lang.reflect.Method;
-import java.util.Collections;
-import java.util.List;
-
 import javafx.collections.FXCollections;
 import javafx.collections.ObservableList;
 import javafx.scene.Group;
@@ -42,6 +38,10 @@
 import javafx.scene.layout.Pane;
 import javafx.scene.layout.Region;
 
+import java.lang.reflect.Method;
+import java.util.Collections;
+import java.util.List;
+
 public class ImplUtils {
 
     private ImplUtils() {
@@ -157,4 +157,24 @@ public static ObservableList<Node> getChildrenReflectively(Parent p) {
 
         return children;
     }
+
+    public static void focusPreviousSibling(Node node) {
+        final ObservableList<Node> children = node.getParent().getChildrenUnmodifiable();
+        final int index = children.indexOf(node);
+        if (index > 0) {
+            children.get(index - 1).requestFocus();
+        } else {
+            node.getParent().requestFocus();
+        }
+    }
+
+    public static void focusNextSibling(Node node) {
+        final ObservableList<Node> children = node.getParent().getChildrenUnmodifiable();
+        final int index = children.indexOf(node);
+        if (index < children.size() - 1) {
+            children.get(index + 1).requestFocus();
+        } else {
+            focusNextSibling(node.getParent());
+        }
+    }
 }

controlsfx/src/main/java/impl/org/controlsfx/ReflectionUtils.java

@@ -26,8 +26,6 @@
  */
 package impl.org.controlsfx;
 
-import javafx.scene.Parent;
-import javafx.scene.control.Control;
 import javafx.scene.control.TableColumnBase;
 import javafx.scene.control.skin.NestedTableColumnHeader;
 import javafx.scene.control.skin.TableHeaderRow;
@@ -133,23 +131,6 @@ public static Integer onScroll(TableViewSkinBase tableViewSkinBase, String metho
         return -1;
     }
 
-    /****************************************************************************************************
-     *
-     * TraversalEngine
-     *
-     ****************************************************************************************************/
-
-    public static void setTraversalEngine(Control control, Object engine) {
-        try {
-            Class<?> parentHelper = Class.forName("com.sun.javafx.scene.ParentHelper");
-            Method method = parentHelper.getMethod("setTraversalEngine", Parent.class, engine.getClass());
-            method.setAccessible(true);
-            method.invoke(parentHelper, control, engine);
-        } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException | ClassNotFoundException e) {
-            throw new RuntimeException("Cannot set Traversal Engine");
-        }
-    }
-
     /****************************************************************************************************
      *
      * Miscellaneous