PropertyEditors now subscribe to the item's ObservableValue even if the editor is read-only #1512
Conversation
|
Hi vatbub, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
|
FYI I just signed the CLA. Cheers :) |
|
Any updates on this? |
|
@Siedlerchr would you like to review this? |
|
I'll take a look alter today |
controlsfx/src/main/java/org/controlsfx/property/editor/AbstractPropertyEditor.java
Outdated
Show resolved
Hide resolved
|
Copyright year needs to be adjusted at the top of the file. |
…n if the editor is read-only
vatbub
force-pushed
the
issue-1511-property-sheet-subscribe-to-read-only-observable-values
branch
from
7ab8798
to
29d40fa
Compare
|
I just rebased the branch, applied the feedback and updated the copyright. Cheers :) |
controlsfx/src/main/java/org/controlsfx/property/editor/AbstractPropertyEditor.java
Outdated
Show resolved
Hide resolved
abhinayagarwal
changed the title
vatbub
deleted the
issue-1511-property-sheet-subscribe-to-read-only-observable-values
branch
|
Thanks guys :) Just as an FYI for myself: Do you have any plans when the next release will happen? |
|
You should be able to use the snapshot relaese in the meantime https://oss.sonatype.org/content/repositories/snapshots/org/controlsfx/controlsfx/11.1.3-SNAPSHOT/ |
|
I have no urgency (I forked and published the project internally in my organization where I added the patch already) and just wanted to know when I can switch back to Maven Central. Again, no urgency, just out of curiosity :) |
|
v11.2.0 is now available in Maven Central |
Fixes issue #1511