Skip to content

Conversation

ya2s
Copy link
Contributor

@ya2s ya2s commented Sep 29, 2025

Description

  • Deduplicate resolved workspace package names and always include a global scope.
  • Align the @commitlint/config-pnpm-scopes tests with the new global scope expectation.

When using a pnpm workspace, it’s not possible to specify a scope for file changes made directly under the root.
I used pnpm add --global as a reference and named the scope global.
https://pnpm.io/ja/cli/add#--global--g

Motivation and Context

The pnpm workspace root often needs commits that touch shared files. Without a shared scope option, commitlint rejects those messages. Adding global keeps the restriction for packages while enabling root-level changes.

Usage examples

// commitlint.config.js
module.exports = {
  extends: ["@commitlint/config-pnpm-scopes"],
};
echo "chore(global): update pnpm-workspace.yaml" | commitlint

How Has This Been Tested?

  • pnpm vitest run --environment node @commitlint/config-pnpm-scopes/index.test.ts
    • (fails in the sandbox because @commitlint/test cannot be resolved; please re-run in a full workspace environment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (Unable to complete locally due to missing dependency in sandbox)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Sweet, thanks!

Do you know by any chance what to do with this?: #4525

@ya2s
Copy link
Contributor Author

ya2s commented Sep 29, 2025

@escapedcat
I’m not very familiar with this, so I can’t give a clear answer🙏

@escapedcat
Copy link
Member

No worries, just wanted to check :)

@escapedcat escapedcat merged commit e571970 into conventional-changelog:master Sep 29, 2025
21 of 22 checks passed
@ya2s
Copy link
Contributor Author

ya2s commented Sep 30, 2025

@escapedcat
Thank you for the merge!
When will the patch release be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants