-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #1443
Merged
Various fixes #1443
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e44f232
fix pint's unicode printing of ohms
bqpd 4a08554
auto-rebuild if settings indicates old gpkit version
bqpd df7f668
fix ohm printing for kiloohms etc.
bqpd 609e04b
fix #1441
bqpd db0a77e
Merge branch 'master' into fixes
bqpd 12cdea6
lint
bqpd 41bb4cc
Merge branch 'fixes' of github.com:convexengineering/gpkit into fixes
bqpd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,9 +70,14 @@ def tight_table(self, _, ntightconstrs=5, tight_senss=1e-2, **kwargs): | |
if not self.model: | ||
return [] | ||
title = "Tightest Constraints" | ||
data = [((-float("%+6.2g" % c.relax_sensitivity), str(c)), | ||
"%+6.2g" % c.relax_sensitivity, id(c), c) | ||
for c in self.model.flat() if c.relax_sensitivity >= tight_senss] | ||
try: | ||
data = [((-float("%+6.2g" % c.relax_sensitivity), str(c)), | ||
"%+6.2g" % c.relax_sensitivity, id(c), c) | ||
for c in self.model.flat() | ||
if c.relax_sensitivity >= tight_senss] | ||
except AttributeError: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agree that this is a better error message! |
||
print("Constraint %s had no `relax_sensitivity` attribute." % c) | ||
return [] | ||
if not data: | ||
lines = ["No constraints had a sensitivity above %+5.1g." | ||
% tight_senss] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there two layers of sgp_parent here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh let me guess, because you can have relaxations and SP approximations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup.