Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vscode to 1.88.0 #565

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

bzy-debug
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 11, 2024

Someone is attempting to deploy a commit to the Github1s Team on Vercel.

A member of the Team first needs to authorize it.

@bzy-debug
Copy link
Contributor Author

bzy-debug commented Apr 11, 2024

One question, does the tsconfig.json in vscode-web work for you guys?

I have to edit it like this to get correct typescript language service:

{
  "include": ["./src/"],
  "compilerOptions": {
    "strict": true,
    "paths": {
      "vs/*": ["./lib/vscode/src/vs/*"]
    }
  }
}

@bzy-debug
Copy link
Contributor Author

any progress on this pr?

@conwnet conwnet changed the base branch from master to bump-vscode April 29, 2024 18:03
@conwnet conwnet merged commit 2a6d114 into conwnet:bump-vscode Apr 29, 2024
12 of 14 checks passed
conwnet added a commit that referenced this pull request Apr 30, 2024
* chore: bump vscode to 1.88.0 (#565)

Co-authored-by: Bao Zhiyuan <baozhiyuan@idea.edu.cn>

* chore: bump vscode to 1.88.1

* chore: bump vscode to 1.88.1

* test: fix tests

---------

Co-authored-by: Bao Zhiyuan <71200607+bzy-debug@users.noreply.github.com>
Co-authored-by: Bao Zhiyuan <baozhiyuan@idea.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants