Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Unicode error on Windows when linting #757

Merged
merged 1 commit into from
Aug 3, 2021
Merged

fix Unicode error on Windows when linting #757

merged 1 commit into from
Aug 3, 2021

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Aug 3, 2021

Signed-off-by: zethson lukas.heumos@posteo.net

Fixes #749

Signed-off-by: zethson <lukas.heumos@posteo.net>
@github-actions github-actions bot added the bug Something isn't working label Aug 3, 2021
@Zethson
Copy link
Member Author

Zethson commented Aug 3, 2021

@e2jk this should fix it, right? Would be happy if you have a minute to test it!

CI failing is due to #756 and not related.

@e2jk
Copy link
Contributor

e2jk commented Aug 3, 2021

@Zethson yes that works.
(I have only tested the creation of the package, not the Docker part that you've also updated, but there should be no reason why it wouldn't work there)

Documenting what I've done:

  • I've put back the version containing the emoticons in C:\Users\<username>\.local\pipx\venvs\cookietemple\Lib\site-packages\cookietemple\create\templates\common_files\{{cookiecutter.commonName}}\.github\release-drafter.yml
  • I've run the cookietemple create and confirmed that the project creation crashes again with the same UnicodeDecodeError exception
  • I've made the change to line 254 of cookietemple/lint/template_linter.py to explictly open the file as UTF-8 encoding
  • Re-running cookietemple create the project is now properly created. SUCCESS!

As far as I'm concerned, you can merge this PR.

@Zethson
Copy link
Member Author

Zethson commented Aug 3, 2021

Thank you very much!

@Zethson Zethson merged commit 452f358 into development Aug 3, 2021
@Zethson Zethson deleted the fix/#749 branch August 11, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants