Migrate to swift6 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI周りも修正する必要があるのか、、 |
tera-ny
force-pushed
the
tera-ny/migrate_swift6
branch
from
f4afe9d to
e030f97
Compare
tera-ny
commented
Aug 29, 2025
| DEVELOPER_DIR: '/Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer' | ||
| strategy: | ||
| matrix: | ||
| xcode: [ 15.4, 16.4 ] |
There was a problem hiding this comment.
Swift-tools-version:6.0 is not supported in Xcode 15.4, so we are ending support for Xcode 15.4 in CI.
|
|
||
| var changes: [UserDefaults.Change<String>] = [] | ||
| let observer = wrapper.addObserver { changes.append($0) } | ||
| addTeardownBlock(observer.invalidate) |
There was a problem hiding this comment.
Since it seems unnecessary to use addTeardownBlock, I removed it.
onoyuuya
approved these changes
Aug 29, 2025
| var observer: UserDefaults.Observation? = userDefaults.observeObject(forKey: "TestKey") { change in | ||
| changes.append(change) | ||
| } | ||
| _ = observer |
tera-ny
force-pushed
the
tera-ny/migrate_swift6
branch
from
fea83a9 to
d4a0c33
Compare
|
マージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift6を有効化して出たエラー、警告を修正しました。