Skip to content

Conversation

ryanpato
Copy link
Contributor

@ryanpato ryanpato commented Nov 18, 2021

Background

Overview

Improve test coverage of swift library and example project by using multiple Xcode versions and device OS (iOS).
Sets the foundation for watchOS and tvOS destinations.

Tasks

  • Add xcpretty to Gem file (used for formatting of output in workflow jobs)
  • Add matrix to ci.yml workflow to support Xcode 12 and 13 devices
  • Build & Run library Unit-Tests on MacOS
  • Build & Run library Unit-Tests on iOS
  • Build & Run Example UI-Tests on iOS

@ryanpato ryanpato self-assigned this Nov 18, 2021
@ryanpato ryanpato force-pushed the rp/xcode-12-13-support branch 6 times, most recently from 186fa71 to a0552e4 Compare November 18, 2021 16:15
@ryanpato ryanpato force-pushed the rp/xcode-12-13-support branch from a0552e4 to a60722b Compare November 18, 2021 16:18
@ryanpato ryanpato marked this pull request as ready for review November 18, 2021 16:36
@ryanpato ryanpato changed the title Add matrix to ci.yml to run checks on iOS and MacOS against Xcode 12 and 13 Run library and example project tests against multiple Xcode versions and device destinations Nov 18, 2021
Copy link
Contributor

@liamnichols liamnichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just one small additional suggestion for updating the job name 🙇

Copy link
Contributor

@liamnichols liamnichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I just updated the branch protection rules so you should be able to merge this now:

Screen Shot 2021-11-19 at 11 52 47

@ryanpato ryanpato merged commit 39e336c into main Nov 19, 2021
@ryanpato ryanpato deleted the rp/xcode-12-13-support branch November 19, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants