Token length = 50 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, any reason to not merge this PR ? |
|
Hello @CharlyPoppins, |
|
Got the issue with mysql Ver 14.14 Distrib 5.5.61-38.13, for debian-linux-gnu (x86_64) using readline 5.1 Also while trying to solve the problem I read that I shouldn't be indexing such long varchar columns because the index will be very bulky and inefficient. According to that, I saw that the generated token was 50 caracters long and I adjusted the varchar lenght. |
|
Thanks @CharlyPoppins. As it's a BC break, it will be tagged in 1.2.0 soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue try to create the table on a MySql datatable. There was a problem creating the Unique index : #1071 - Specified key was too long; max key length is xxx bytes
Solve the problem by reducing varchar length.