Re-architecture the "TaskList" entity in the backend #4267
Conversation
Atala
force-pushed
the
revamp-tasklist
branch
2 times, most recently
from
b36c506
to
177d402
Compare
Atala
force-pushed
the
revamp-tasklist
branch
3 times, most recently
from
4360fb4
to
089ce11
Compare
There was a problem hiding this comment.
not yet
actually TaskCollection (ordered set of tasks, which has a distance and polyline) is an abstract class/base class that has now two implementations Delivery and Tours (TaskList was but not anymore).
for your information we use doctrine inheritance mapping to translate this abstraction to the database-level.
(I am not really fond of this both on the code side or database side as it adds complexity to the understanding of both the code and the codebase, but it is like this for now)
There was a problem hiding this comment.
In my opinion it's better to avoid such generic subscribers and have specialized classes instead, where each class has more focused set of actions/responsibilities. See Domain\Order\Reactor package, for example
js/app/dashboard/components/Tour.js
Outdated
| const Tour = ({ tour, tourId, draggableIndex }) => { | ||
|
|
||
| if (!tour && tourId) { | ||
| tour = useSelector(state => selectTourById(state, tourId)) |
There was a problem hiding this comment.
Hooks should not be called conditionally: https://react.dev/reference/rules/rules-of-hooks#only-call-hooks-at-the-top-level
Atala
changed the title
Solves also #4007