-
Notifications
You must be signed in to change notification settings - Fork 69
Nueva lengua: portugués Brasil #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gemfile
Outdated
@@ -59,6 +59,7 @@ group :development, :test do | |||
gem "rspec-rails", '~> 3.4.0' | |||
gem "capybara", '~> 2.4.4' | |||
gem "byebug" | |||
gem "localeapp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Podemos fijar una version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ni idea
config/initializers/localeapp.rb
Outdated
require 'localeapp/rails' | ||
|
||
Localeapp.configure do |config| | ||
config.api_key = 'uKIILTtzVqqZQlQErIReCFLP5rbX28jGGx8pxhP8JZTSIVwak5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta API key deberiamos cambiarla y guardarla en otro sitio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you wish ;)
config/locales/ar.yml
Outdated
@@ -0,0 +1,504 @@ | |||
ar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ar
? hace falta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Están puestas varias lenguas que luego no se usan, simplemente porqué aguien djo que las traduciria y en localeapp.com estan creadas https://www.localeapp.com/projects/10031 si finalmente no se traducen ya las volveremos a borrar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si no hay, no hay. cuando alguien quiera las anyade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, si molestan los yml vacios pues se borran
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sí, por favor
config/locales/eu.yml
Outdated
@@ -0,0 +1,504 @@ | |||
eu: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eu
? hace falta?
README.md
Outdated
- **That's it!** | ||
- The maintainer will then pull translations from the Locale project and push to Github. | ||
|
||
Happy translating! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esto deberia ir al CONTRIBUTING
no? se me hace raro que esté debajo de la licencia cuando ya hay un apartado de Contribuciones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya... creo que a GEM lo agrega automáticamente
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vaya que raro, no lo habia visto nunca. Un poco "intrusivo", la verdad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si CONTRIBUTING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Que alguien mas lo arranque en local y lo pruebe y podemos darle a merge.
👏 @sseerrggii 👏
Gestionamos las traducciones en localeapp https://www.localeapp.com/projects/10031
Una colaboradora ha añadido portugués de Brasil y lo he añadido a la rama