Skip to content

Conversation

sseerrggii
Copy link
Contributor

Gestionamos las traducciones en localeapp https://www.localeapp.com/projects/10031

Una colaboradora ha añadido portugués de Brasil y lo he añadido a la rama

Gemfile Outdated
@@ -59,6 +59,7 @@ group :development, :test do
gem "rspec-rails", '~> 3.4.0'
gem "capybara", '~> 2.4.4'
gem "byebug"
gem "localeapp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos fijar una version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ni idea

require 'localeapp/rails'

Localeapp.configure do |config|
config.api_key = 'uKIILTtzVqqZQlQErIReCFLP5rbX28jGGx8pxhP8JZTSIVwak5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta API key deberiamos cambiarla y guardarla en otro sitio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish ;)

@@ -0,0 +1,504 @@
ar:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ar? hace falta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Están puestas varias lenguas que luego no se usan, simplemente porqué aguien djo que las traduciria y en localeapp.com estan creadas https://www.localeapp.com/projects/10031 si finalmente no se traducen ya las volveremos a borrar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si no hay, no hay. cuando alguien quiera las anyade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, si molestan los yml vacios pues se borran

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sí, por favor

@@ -0,0 +1,504 @@
eu:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eu? hace falta?

README.md Outdated
- **That's it!**
- The maintainer will then pull translations from the Locale project and push to Github.

Happy translating!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esto deberia ir al CONTRIBUTING no? se me hace raro que esté debajo de la licencia cuando ya hay un apartado de Contribuciones

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya... creo que a GEM lo agrega automáticamente

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaya que raro, no lo habia visto nunca. Un poco "intrusivo", la verdad.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si CONTRIBUTING

Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que alguien mas lo arranque en local y lo pruebe y podemos darle a merge.

👏 @sseerrggii 👏

@sseerrggii sseerrggii merged commit 479fdc9 into develop Aug 1, 2017
@sseerrggii sseerrggii deleted the localeapp branch August 1, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants