Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to MathComp 2 #24

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jun 8, 2023

This requires MathComp 2 and is not backward compatible.

@proux01 proux01 marked this pull request as ready for review June 8, 2023 18:46
@proux01
Copy link
Contributor Author

proux01 commented Jun 8, 2023

CI "green": the failures correspond to no longer supported versions of Coq.

@palmskog
Copy link
Member

@proux01 I did a release for 1.X, so maybe this could be rebased (and merged when CI passes)?

@palmskog
Copy link
Member

@proux01 OK, it looks like everything that is supposed to pass passes, so is this ready to merge?

It would be nice to add Docker jobs for mathcomp-dev:coq-dev also, but if you prefer, I can do that after the merge.

@proux01 proux01 force-pushed the hierarchy-builder branch 2 times, most recently from 3afc71c to 18f600e Compare June 19, 2023 15:53
@proux01
Copy link
Contributor Author

proux01 commented Jun 19, 2023

@palmskog done, CI green

@palmskog palmskog merged commit 8efbcdc into coq-community:master Jun 19, 2023
@proux01 proux01 deleted the hierarchy-builder branch June 19, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants