-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nix infrastructure #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to git add
config.nix
and shellHook.sh
?
ed683f3
to
2dcbdb9
Compare
@Zimmi48 I reached something satisfactory, want to talk about it? |
2dcbdb9
to
9e760d2
Compare
Sure! I'm available anytime tomorrow, Tuesday or next Thursday/Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos in the documentation of config.nix
.
woops ;) |
- documenting the config file - entries in ref.yml
I think there should be two distinct docs anyway: one on Anyway |
I'm not sure anymore (I did not expect to reach that level of automated generation when I started...) |
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
Yeah, me neither! Anyway, my opinion is that having to copy the template fallback config to a new file was fine when you couldn't do most things except by hand but now it doesn't really make sense anymore. So what I suggest is to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check that this is still compatible with the latest version of the toolbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed to default.nix.mustache
to use the latest version of the toolbox.
/!\ is discouraged in favor of `token` below. | ||
example: | ||
- "CACHIX_SIGNING_KEY" | ||
- token: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we could set a default value for this token
if community
is true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I tried with this patch but it didn't work:
diff --git a/nix-action.yml.mustache b/nix-action.yml.mustache
index 3f67a5c..60a4e9f 100644
--- a/nix-action.yml.mustache
+++ b/nix-action.yml.mustache
@@ -39,6 +39,21 @@ jobs:
<%# token%>
authToken: '${{ secrets.<%token%> }}'
<%/ token%>
+<%/ cachix%>
+<%^ cachix%>
+<%# community%>
+ - name: Cachix setup coq
+ uses: cachix/cachix-action@v8
+ with:
+ # Name of a cachix cache to pull/substitute
+ name: coq
+ - name: Cachix setup coq-community
+ uses: cachix/cachix-action@v8
+ with:
+ # Name of a cachix cache to pull/substitute
+ name: coq-community
+ authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
+<%/ community%>
<%/ cachix%>
- name: Git checkout
uses: actions/checkout@v2
@@ -87,6 +102,21 @@ jobs:
<%# token%>
authToken: '${{ secrets.<%token%> }}'
<%/ token%>
+<%/ cachix%>
+<%^ cachix%>
+<%# community%>
+ - name: Cachix setup coq
+ uses: cachix/cachix-action@v8
+ with:
+ # Name of a cachix cache to pull/substitute
+ name: coq
+ - name: Cachix setup coq-community
+ uses: cachix/cachix-action@v8
+ with:
+ # Name of a cachix cache to pull/substitute
+ name: coq-community
+ authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
+<%/ community%>
<%/ cachix%>
- name: Git checkout
uses: actions/checkout@v2
My Mustache is too rusty for me to understand what the problem is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did manage to do something similar with default Cachix instances and default Cachix pushing for coq-community projects in #99.
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
required: false | ||
type: string | ||
description: Change the pinned rev of coq-nix-toolbox | ||
- nix-dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to be provided as the nix
field of the dependencies
list. Would it be possible to reuse this (less conversion of projects using the former infrastructure)? If not, we should remove this unused field from the documentation.
This PR cannot be merged until coq-community/coq-nix-toolbox#49 is fixed. |
At this stage, my opinion is that it's better if we don't have to maintain three different complex CI generation procedures, so it would make sense to only focus on the generation mechanism of the standalone installation procedure, and to only provide a lightweight CI template here like in #99. So I propose to close this. |
@CohenCyril: do you agree with my suggestion of closing this and recommending either a full Coq Nix Toolbox setup with a standalone installation or a lightweight CI generation mechanism with the current version of the templates (following #99)? |
Ok! I'd rather keep the branch though... |
CC @Zimmi48