Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl: Fix compilation with shmem feature enabled #2722

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

acheroncrypto
Copy link
Collaborator

Problem

anchor-spl crate doesn't compile with all features enabled because shmem feature is broken.

error[E0412]: cannot find type `Pubkey` in this scope
  --> spl/src/shmem.rs:36:10
   |
36 | #[derive(Accounts)]
   |          ^^^^^^^^ not found in this scope
   |
   = help: consider importing one of these items:
           anchor_lang::prelude::Pubkey
           solana_program::example_mocks::solana_sdk::Pubkey
   = note: this error originates in the derive macro `Accounts` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `Pubkey` in this scope
  --> spl/src/shmem.rs:43:10
   |
43 | #[derive(Accounts)]
   |          ^^^^^^^^ not found in this scope
   |
   = help: consider importing one of these items:
           anchor_lang::prelude::Pubkey
           solana_program::example_mocks::solana_sdk::Pubkey
   = note: this error originates in the derive macro `Accounts` (in Nightly builds, run with -Z macro-backtrace for more info)

Summary of changes

Import solana_program::pubkey::Pubkey.


Might also remove this feature since the program doesn't seem to be deployed so nobody is using it but let's keep it for now since the fix was easy.

Copy link

vercel bot commented Dec 8, 2023

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto merged commit 8bf7f25 into coral-xyz:master Dec 8, 2023
47 of 48 checks passed
@staccDOTsol
Copy link

@acheroncrypto I'm finna deploy it maybe

@acheroncrypto
Copy link
Collaborator Author

What is the use case? We removed it in #2747, though it wasn't much anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants