ci: Test anchor-spl during downstream build #34368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: acheron <98934430+acheroncrypto@users.noreply.github.com>
|
@acheroncrypto btw, since we checkout a version tag for the downstream build, we'll keep getting the error on the build since 0.29.0 has the issue. do you plan to tag 0.29.1 or should I wait until 0.30.0 to add the |
|
Can we just enable the features we want in order to make this work now without requiring a new release? rust-lang/cargo#11467 would help a lot here but for now, we can do: These are the additional features we'd want to test since token features are enabled by default. |
|
Ok great, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
According to the Anchor team, we should also make sure that
anchor-splworks during our downstream checks.Summary of Changes
Add a step to test anchor-spl with all features enabled.
@acheroncrypto I can't add you as a reviewer, but can you double-check that this is correct?
Note: This is blocked by coral-xyz/anchor#2722, so keeping it in draft
Fixes #