Settings in stream #109
Merged
Settings in stream #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
requested changes
Nov 28, 2016
| case 'post': | ||
| return Promise.all([Comment.findAcceptedAndNewByAssetId(asset.id), asset, settings]); | ||
| default: | ||
| return Promise.reject(new Error('Moderation setting not found.')); | ||
| } |
There was a problem hiding this comment.
The switch was replaced because the default described in the database is "pre". Because there can be only two states it made sense to not complain in the event of a missing setting. I'd prefer to retain this as the single if check as before and simply add the settings object to the returned Promise.all below.
There was a problem hiding this comment.
@wyattjoh, this change has been implemented.
wyattjoh
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves settings to the stream call
How do I test this PR?
api/v1/settingsconfigsection of the store