Flag username #133

davidgljay · 2016-12-08T03:29:24Z

What does this PR do?

Allows a user to flag a username or comment and provide details.

How do I test this PR?

Click "Report" underneath a comment.
Select whether to report a comment or username. Click continue.
Select a reason or enter one via "other." Click continue.
If you flagged the comment, the flag should be red.
If you flagged the username, it should stay black.
Check the network panel, action should be posted to the server at /v1/api/comments/:comment_id/actions or /v1/api/users/:user_id/actions

impronunciable · 2016-12-08T17:55:56Z

I really like how it works :)
The popup is not hiding even clicking outside

impronunciable · 2016-12-08T17:56:29Z

client/coral-embed-stream/src/CommentStream.js

@@ -272,8 +274,8 @@ const mapDispatchToProps = (dispatch) => ({
  getStream: (rootId) => dispatch(getStream(rootId)),
  addNotification: (type, text) => dispatch(addNotification(type, text)),
  clearNotification: () => dispatch(clearNotification()),
+  postAction: (item, action, itemType, field, detail) => dispatch(postAction(item, action, itemType, field, detail)),


At this point we should use an object instead of positional arguments

I'm using onClickOutside or something like that in Permalink if you want to check it out @davidgljay

impronunciable · 2016-12-08T17:57:04Z

client/coral-framework/actions/items.js

@@ -217,11 +217,12 @@ export function postItem (item, type, id) {
 *
 */

-export function postAction (item_id, action_type, user_id, item_type) {
+export function postAction (item_id, action_type, item_type, field, detail) {


same as above, too many positional params

impronunciable · 2016-12-08T17:58:07Z

client/coral-plugin-flags/FlagButton.js

+        header: lang.t('step-1-header'),
+        options: [
+          {val: 'user', text: lang.t('flag-username')},
+          {val: 'comments', text: lang.t('flag-comment')},


remove extra comma

I think there are extra commas in every array, if this is intended that's ok

impronunciable · 2016-12-08T18:00:08Z

models/action.js

@@ -35,12 +37,14 @@ ActionSchema.statics.findById = function(id) {
 * @param {String} action the new action to the comment
 * @return {Promise}
 */
-ActionSchema.statics.insertUserAction = ({item_id, item_type, user_id, action_type}) => {
+ActionSchema.statics.insertUserAction = ({item_id, item_type, user_id, action_type, field, detail}) => {


Too many params

The alternative is to pass in a whole object, which seems messy (and frought, see @wyatt's comments below.) I'm leaving this as is.

…ckend.

wyattjoh · 2016-12-08T20:31:45Z

routes/api/comments/index.js

  Comment
-    .addAction(req.params.comment_id, req.user.id, action_type)
+    .addAction(req.params.comment_id, req.user.id, req.body)


We should extract only the parameters we need from the body, not the whole one, this would result in anyone being able to stuff whatever they want in our db.

wyattjoh · 2016-12-08T20:32:44Z

models/comment.js

  item_id,
  item_type: 'comment',
  user_id,
-  action_type
+  action


This style (hiding fields inside this new action value) makes this difficult to read.

Agreed, @dan requested this change. I can revert.

wyattjoh · 2016-12-08T20:32:54Z

models/user.js

+  item_id,
+  item_type: 'comment',
+  user_id,
+  action


Same as above.

wyattjoh · 2016-12-08T20:33:17Z

routes/api/user/index.js

+router.post('/:user_id/actions',  authorization.needed(), (req, res, next) => {
+
+  User
+    .addAction(req.params.comment_id, req.user.id, req.body)


Same as above, we shouldn't just pull the entire body.

…n the backend." This reverts commit 9d28577.

impronunciable · 2016-12-08T20:55:51Z

I still can't get rid of the popup

impronunciable · 2016-12-08T21:58:00Z

Functionality is there :)

wyattjoh · 2016-12-08T21:59:04Z

routes/api/user/index.js

@@ -158,9 +158,15 @@ router.put('/:user_id/bio', (req, res, next) => {
 });

 router.post('/:user_id/actions',  authorization.needed(), (req, res, next) => {
+  console.log('Hit action endpoint');


Seems this one snuck through

Oops! My apologies.

wyattjoh · 2016-12-08T21:59:41Z

tests/routes/api/comments/index.js

@@ -350,7 +350,7 @@ describe('/api/v1/comments/:comment_id/actions', () => {
      return chai.request(app)
        .post('/api/v1/comments/abc/actions')
        .set(passport.inject({id: '456', roles: ['admin']}))
-        .send({'action_type': 'flag'})
+        .send({'user_id': '456', 'action_type': 'flag'})


This shouldn't actually do anything, should revert this line.

jde · 2016-12-09T19:27:41Z

This is looking amazing! Two details:

Agree that we need a close button on the last step. Clicking off the modal "works" but I would argue is not a good UI solution.
When data is put in the action collection, the item_id field is null:

jde · 2016-12-09T19:55:53Z

@losowsky confirmed the need to close:

We should always have the ability to close the box (currently if you're in the flow, there's not way to get out.) Clicking off the box should always close it (it doesn't close now if you're on step 2.)

davidgljay added 16 commits December 5, 2016 15:59

Adding popup on report button click.

a9bc906

Showing first set of options in menu.

ab43d1f

Styling popup menu.

5e8315c

Adding options to popup menu.

9da19e8

Posting flag action.

3438024

Updating postAction to send reasons to backend.

13d0dec

Adding text to postAction in commentStream.

9e69a45

Merge branch 'master' of github.com:coralproject/talk into flag-username

507e89a

Cleaning up after merge.

74eb09a

Posting actions to comment and user endpoints.

713cc0c

Updating style.

a8805b4

Enabling i18n

3be1556

Addressing setting bug caused by open thread feature.

18f7b07

Adding other field.

dd85fbb

Merge branch 'master' of github.com:coralproject/talk into flag-username

6fc3f00

Updating tests.

f8923aa

impronunciable reviewed Dec 8, 2016

View reviewed changes

davidgljay added 4 commits December 8, 2016 14:27

Compressing variables from postAction into single object.

fc96c1e

Closing Report menu when a user clicks outside of it.

191681d

Merge branch 'master' of github.com:coralproject/talk into flag-username

b3d84d7

Removing extra commas and collapsing actions into an object in the ba…

9d28577

…ckend.

wyattjoh requested changes Dec 8, 2016

View reviewed changes

davidgljay added 2 commits December 8, 2016 15:47

Revert "Removing extra commas and collapsing actions into an object i…

7f24153

…n the backend." This reverts commit 9d28577.

Removing commas.

e4a13d4

Fixing bug in addItem in commentStream.

f0108e1

wyattjoh reviewed Dec 8, 2016

View reviewed changes

davidgljay added 2 commits December 9, 2016 13:24

Updating tests and removing unecessary log statement.

b101882

Merge branch 'master' of github.com:coralproject/talk into flag-username

bf01543

Addressing null item_id in user flagging.

922fc63

wyattjoh approved these changes Dec 9, 2016

View reviewed changes

davidgljay added 5 commits December 9, 2016 15:47

Adding Done button to last step of flagging menu.

8e432aa

Merge branch 'master' of github.com:coralproject/talk into flag-username

90ef16e

Avoiding double-posting.

acd57e4

Merge branch 'master' of github.com:coralproject/talk into flag-username

f5ac576

Making itemType consistent on backend.

ecbdc5d

davidgljay merged commit be760bd into master Dec 9, 2016

riley deleted the flag-username branch December 12, 2016 18:08

snyk-bot mentioned this pull request Jul 28, 2020

[Snyk] Security upgrade hexo-renderer-marked from 0.3.2 to 3.0.0 icco/talk#36

Open

snyk-bot mentioned this pull request Dec 8, 2020

[Snyk] Fix for 1 vulnerabilities icco/talk#46

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flag username #133

Flag username #133

davidgljay commented Dec 8, 2016

impronunciable commented Dec 8, 2016

impronunciable Dec 8, 2016

riley Dec 8, 2016

impronunciable Dec 8, 2016

impronunciable Dec 8, 2016

impronunciable Dec 8, 2016

impronunciable Dec 8, 2016

davidgljay Dec 8, 2016

wyattjoh Dec 8, 2016

wyattjoh Dec 8, 2016

davidgljay Dec 8, 2016

wyattjoh Dec 8, 2016

wyattjoh Dec 8, 2016

impronunciable commented Dec 8, 2016

impronunciable commented Dec 8, 2016

wyattjoh Dec 8, 2016

davidgljay Dec 9, 2016

wyattjoh Dec 8, 2016

jde commented Dec 9, 2016 •

edited

Loading

jde commented Dec 9, 2016

Flag username #133

Flag username #133

Conversation

davidgljay commented Dec 8, 2016

What does this PR do?

How do I test this PR?

impronunciable commented Dec 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

impronunciable commented Dec 8, 2016

impronunciable commented Dec 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jde commented Dec 9, 2016 • edited Loading

jde commented Dec 9, 2016

jde commented Dec 9, 2016 •

edited

Loading