[CORL-3006]: Enable anonymous DSA reporting #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
approved these changes
Dec 20, 2023
Comment on lines
+29
to
36
| let anonymousWithDSA = false; | ||
| if (!viewer) { | ||
| return null; | ||
| if (!settings.dsa?.enabled) { | ||
| return null; | ||
| } else { | ||
| anonymousWithDSA = true; | ||
| } | ||
| } |
There was a problem hiding this comment.
What are your thoughts on this logic? For me, it improves read-ability, but I have a feeling I might be in the minority due to it relying on ?. operator.
const anonymousWithDSA = !viewer && settings.dsa?.enabled;
if (!settings.dsa?.enabled && !viewer) {
return null;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes enable DSA reports to be made by users who are not signed in. If a user is not signed in, and DSA is enabled, then when they hit the
Reportbutton for a comment, they will go into a flow that allows them to report illegal content but provides the info that to report a comment in any other way, they must sign in.If DSA is not enabled, the report flow remains as is.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
userIDis no longer required for a DSA reportDoes this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test this PR by enabling DSA and ensuring you are logged out. Click
Reportfor a comment in the stream. See that it says "Report This Comment" and "You have to sign in to report a comment". You should also see a link to report the comment for illegal content. Click that link. Stay signed out and fill out the DSA report. ClickSubmit report. You should see a submission success screen. Now log in to the admin and go to theDSA Reportstab. Find the new report you just created. ForReported byin the overall reports table, it should sayAnonymous user. Click through to that report's individual page. ForReporter, it should sayAnonymous user. Download the report's CSV. In theUsercolumn, it should say "Anonymous user`.Sign in and report a DSA report. All should still be as before, you should be able to create your report and see the reporter displayed.
Disable DSA. Try to report a comment signed in/out and see that the flow is still as it was. Signed out, you are prompted to sign in before reporting. Signed in, you go to the report form.
Archived comment report flow remains the same, as it doesn't require being signed in.
Were any tests migrated to React Testing Library?
How do we deploy this PR?