Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSA fix: only check for duplicate report if not anonymous user #4486

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Jan 17, 2024

What does this PR do?

Update so that we only check for duplicate DSA reports submitted by a user for a particular comment if the user is signed in and it is not an anonymous report.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Make sure you're signed out. Try to DSA report the same comment twice. See that there are no errors and both show in the DSA Reports tab.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for gallant-galileo-14878c ready!

Name Link
🔨 Latest commit 0b33291
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65a813a13769e30008374532
😎 Deploy Preview https://deploy-preview-4486--gallant-galileo-14878c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@nick-funk nick-funk added this pull request to the merge queue Jan 17, 2024
Merged via the queue into develop with commit 382afd4 Jan 17, 2024
6 checks passed
@nick-funk nick-funk deleted the fix/anonymous-dsa-duplicate-comment-report branch January 17, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants