tests/e2e-update: Bump to f34 grub

[cgwalters]

Need to tweak this to auto-detect gold versus updates, or
probably better just synthesize an update.

[lucab]

I admittedly don't understand much about the CI setup here, but you did previously NAK this exact patch at #184 (comment) so I have the feeling this isn't really the path you wanted to follow.

[cgwalters]

but you did previously NAK this exact patch at #184 (comment) so I have the feeling this isn't really the path you wanted to follow.

Hah. Oops. Thanks for pointing that out. Clearly the bespoke CI setup here has escaped my ability to understand it.

[cgwalters]

Hum, interesting.

�[2J�[01;01H�[=3h�[2J�[01;01H�[0m�[35m�[40m�[0m�[37m�[40mBdsDxe: loading Boot0001 "UEFI Misc Device" from PciRoot(0x0)/Pci(0x7,0x0)
BdsDxe: starting Boot0001 "UEFI Misc Device" from PciRoot(0x0)/Pci(0x7,0x0)
�[0m�[37m�[44m�[01;01HÚÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ¿�[02;01H³                           Boot Option Restoration                            ³�[03;01H³                                                                              ³�[04;01H³                                                                              ³�[05;01H³                                                                              ³�[06;01H³                                                                              ³�[07;01H³                                                                              ³�[08;01H³                                                                              ³�[09;01H³                                                                              ³�[10;01H³                                                                              ³�[11;01H³                                                                              ³�[12;01H³                                                                              ³�[13;01H³                                                                              ³�[14;01H³                                                                              ³�[15;01H³                                                                              ³�[16;01H³                                                                              ³�[17;01H³                                                                              ³�[18;01H³                                                                              ³�[19;01H³                                                                              ³�[20;01H³                                                                              ³�[21;01H³                                                                              ³�[22;01H³                                                                              ³�[23;01H³                                                                              ³�[24;01HÀÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÙ�[13;24HPress any key to stop system reset�[23;03HBooting in 5 seconds  �[23;03HBooting in 4 seconds  �[23;03HBooting in 3 seconds  �[23;03HBooting in 2 seconds  �[23;03HBooting in 1 second   �[03;01H�[0m�[37m�[40mReset System
�[2J�[01;01H�[=3h�[2J�[01;01H�[0m�[35m�[40m�[0m�[37m�[40mBdsDxe: loading Boot0003 "Fedora" from HD(2,GPT,18A4ECF1-589D-4677-9041-31B8C1047AFB,0x1000,0x3F800)/\EFI\fedora\shimx64.efi
BdsDxe: starting Boot0003 "Fedora" from HD(2,GPT,18A4ECF1-589D-4677-9041-31B8C1047AFB,0x1000,0x3F800)/\EFI\fedora\shimx64.efi
error: ../../grub-core/commands/search.c:296:no such device: boot.

�[0m�[30m�[40m�[2J�[01;01H�[0m�[37m�[40merror: ../../grub-core/commands/boot.c:146:you need to load the kernel first.

�[0m�[30m�[40m�[2J�[01;01H�[0m�[37m�[40m      Minimal BASH-like line editing is supported. For the first word,    

      TAB lists possible command completions. Anywhere else TAB lists     

      possible device or file completions.                                



grub> 

This looks like we're just dead at the UEFI console, which implies we may have broken things, or FCOS broke somehow here.

[cgwalters]

OK this is easily replicable locally, which is cool. However, I still have no idea what's going wrong. It looks like the underlying error is:

error: ../../grub-core/commands/search.c:296:no such device: boot.

But I can boot the image in bios mode just fine, and I see a filesystem with label=boot as expected.

[cgwalters]

OK so inverting the order of the grub builds made things pass for me. I think grub2-2.06~rc1-3.fc34 is just broken. (And here we're not rebooting into it, just using it as an upgrade target).

What we clearly should be doing instead is synthesizing an RPM with modified binaries, to avoid any dependency on versions or random GRUB builds.

[bgilbert]

LGTM, thanks.

[travier]

LGTM with @bgilbert suggestion but why does that comment not apply anymore?

[cgwalters]

why does that comment not apply anymore?

I was wrong previously; see this bit which does inject the binaries-under-test:

bootupd/.cci.jenkinsfile

Line 48 in d901c5f

mv insttree/* overrides/rootfs/

We can also cross-verify after this merges with a PR that breaks bootupd.