Ensure container image layers are pruned #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was debugging something else and stumbled into this; not heavily tested yet but I think this was a regression from 2ed82ee
cgwalters
force-pushed
the
ensure-layer-prune
branch
from
9047b0c
to
2584497
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Dec 9, 2023
This is kind of a usability regression from ostreedev@979b93a "deploy: Add an API to prune undeployed images" This new API and CLI make it convenient to prune the images, the layers, *and* the underlying objects. cc coreos/rpm-ostree#4720 This API in particular is what bootc wants. For rpm-ostree we do still want to separate pruning refs from objects, because rpm-ostree may have layered packages, and we only want to traverse the ostree repo to prune objects once.
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Dec 9, 2023
This is kind of a usability regression from ostreedev@979b93a "deploy: Add an API to prune undeployed images" This new API and CLI make it convenient to prune the images, the layers, *and* the underlying objects. cc coreos/rpm-ostree#4720 This API in particular is what bootc wants. For rpm-ostree we do still want to separate pruning refs from objects, because rpm-ostree may have layered packages, and we only want to traverse the ostree repo to prune objects once.
|
OK and this one is a pretty important bugfix and may even warrant backporting/cherry picking. |
jmarrero
approved these changes
Dec 12, 2023
That one's just in tests, we aren't currently gating on it. |
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Dec 15, 2023
This will ensure we're really pruning everything. xref coreos/rpm-ostree#4720 Signed-off-by: Colin Walters <walters@verbum.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging something else and stumbled into this; not heavily tested yet but I think this was a regression from 2ed82ee