This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Add convenient API/CLI to prune all content #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kind of a usability regression from ostreedev@979b93a "deploy: Add an API to prune undeployed images" This new API and CLI make it convenient to prune the images, the layers, *and* the underlying objects. cc coreos/rpm-ostree#4720 This API in particular is what bootc wants. For rpm-ostree we do still want to separate pruning refs from objects, because rpm-ostree may have layered packages, and we only want to traverse the ostree repo to prune objects once.
cgwalters
force-pushed
the
really-prune
branch
from
6219743
to
74ccd40
Compare
cgwalters
force-pushed
the
really-prune
branch
from
74ccd40
to
b99bc8c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add convenient API/CLI to prune all content
This is kind of a usability regression from
979b93a
"deploy: Add an API to prune undeployed images"
This new API and CLI make it convenient to prune the images,
the layers, and the underlying objects.
cc coreos/rpm-ostree#4720
This API in particular is what bootc wants. For rpm-ostree
we do still want to separate pruning refs from objects, because
rpm-ostree may have layered packages, and we only want to traverse
the ostree repo to prune objects once.
deploy: (style) Move external crates before internal
This is preferred style.