[Cart] fix existing cart initalization on customer login #1779
Conversation
|
also see #1699 |
| @@ -73,6 +75,7 @@ public function findCartById($id): ?OrderInterface | |||
| { | |||
| $list = $this->getList(); | |||
| $list->setCondition('o_id = ? AND order__id is null ', [$id]); | |||
| $list->setLimit(1); | |||
There was a problem hiding this comment.
that should always ever return one or null since we directly filter on o_id.
There was a problem hiding this comment.
yes, but as far as i know, the query is faster with a limit, even if you won't notice it in reality :)
There was a problem hiding this comment.
I am not sure, it feels wrong here, so please remove it
| @@ -41,6 +41,7 @@ public function findNamedForCustomer(CustomerInterface $customer, $name): ?Order | |||
| { | |||
| $list = $this->getList(); | |||
| $list->setCondition('customer__id = ? AND name = ? AND order__id is null', [$customer->getId(), $name]); | |||
| $list->setLimit(1); | |||
There was a problem hiding this comment.
is not right here, named can return multiple carts
There was a problem hiding this comment.
hm, but then is the following code below wrong:
if (count($objects) === 1 && $objects[0] instanceof OrderInterface) { return $objects[0]; }
because only one cart will returned?
There was a problem hiding this comment.
is this function somewhere in use @dpfaffenbauer? i can't find a usage in coreshop, if not then how about to return the found collection of carts?
There was a problem hiding this comment.
true, it always ever return if it is one. We don't have any usage of it CoreShop. I don't think it even works... So we should remove it with 3.0
| @@ -58,6 +59,7 @@ public function findLatestByStoreAndCustomer(StoreInterface $store, CustomerInte | |||
| $list->setCondition('customer__id = ? AND store = ? AND order__id is null ', [$customer->getId(), $store->getId()]); | |||
| $list->setOrderKey('o_creationDate'); | |||
| $list->setOrder('DESC'); | |||
| $list->setLimit(1); | |||
|
thanks |
specially on findLatestByStoreAndCustomer it can happen that more then one cart exists for the customer, when the user has logged in, he has been shown an empty cart. although several carts exist, the last cart should be loaded.