Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IndexBundle] Migrate to SettingsStoreAwareInstaller #1847

Merged
merged 2 commits into from
Jan 24, 2022
Merged

[IndexBundle] Migrate to SettingsStoreAwareInstaller #1847

merged 2 commits into from
Jan 24, 2022

Conversation

aarongerig
Copy link
Contributor

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no

This PR implements the SettingsStoreAwareInstaller for the CoreShopIndexBundle.

@aarongerig aarongerig changed the title feat: implement SettingsStoreAwareInstaller for IndexBundle [IndexBundle] Migrate to SettingsStoreAwareInstaller Jan 21, 2022
@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Jan 24, 2022
@dpfaffenbauer dpfaffenbauer merged commit 440cb32 into coreshop:master Jan 24, 2022
@dpfaffenbauer
Copy link
Member

thanks a lot @aarongerig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solverat solverat solverat left review comments

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@aarongerig aarongerig

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongerig @dpfaffenbauer @solverat