-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support class names whose name begins with lowercase letter #1896
Support class names whose name begins with lowercase letter #1896
Conversation
@BlackbitNeueMedien I fixed tests for 2.2, can you rebase to latest 2.2? |
…r-case-class-names
Have I missed something? I merged up-to-date 2.2 branch but it complains about missing database columns. |
|
||
$classStackPimcoreClassName[$alias][] = $class; | ||
try { | ||
$reflectionClass = new ReflectionClass($definition['classes']['model']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlackbitNeueMedien this can be tricky, the class could not exist yet, since they either weren't installed yet or not created yet.
The problem still exists, also in 3.0 - do you know why you closed it, @dpfaffenbauer ? Because #1896 (review) can be easily fixed. |
This is actually quite difficult to solve. Problem is that during Container build time the ClassDefinitions cannot be loaded cause some of them require the kernel to be booted. So to fix this, I load the tokens from the definition file and try to find the classname, feels a bit dirty to me honestly, you might wanna check: #2097 |
Steps to reproduce bug:
\CoreShop\Component\Core\Model\Product
Products
condition, click "Search" -> you see that the defined Product class is not preselected.The other fixed thing is when you override a data object class and set
core_shop_product.pimcore.product.classes.model
to the overridden FQCN (e.g. \App\Model\DataObject\Product), thenCoreShop/src/CoreShop/Bundle/ResourceBundle/DependencyInjection/Compiler/StackClassesPass.php
Line 58 in aff8053