#1613 TagManagerEnhancedEcommerce #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing some of the listed issues in the ticket Fixed: - trackCheckoutComplete - Rename total to revenue - trackProductImpression - remove quantity, brand, position, attribute - trackCartAdd - quantity is hardcoded to 1. Use $quantity instead Template issues - product_impression.js.twig - product_view.js.twig - checkout.js.twig - checkout_complete.js.twig Not fixed: - trackProductImpression - submit impression as multi- instead of single-array - trackCartAdd - price attribute: I'm not sure about that but I think we need to use the cart item price instead of product price (which often can't be determinate (because of complex variant structure etc.) - trackCartRemove
|
|
dpfaffenbauer
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing some of the listed issues in the ticket
Fixed:
Template issues
Not fixed:
TagManagerEnhancedEcommerce
fixing some of the listed issues in the ticket #1613
Fixed:
Template issues
Not fixed: