Check first if metatitle is not null before setting it SEO TitleExtractor #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalheidmann
changed the title
dpfaffenbauer
previously approved these changes
Mar 28, 2023
|
@pascalheidmann please rebase to 3.0 |
|
ping @pascalheidmann |
pascalheidmann
force-pushed
the
optional-seo-metadata
branch
from
aad9883
to
b09d239
Compare
pascalheidmann
force-pushed
the
optional-seo-metadata
branch
from
95d4a6b
to
cfc49e6
Compare
|
@dpfaffenbauer hope correct originn & target branches now |
dpfaffenbauer
approved these changes
Apr 9, 2023
|
thanks a lot @pascalheidmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaTitle can be null according to interface
CoreShop\Component\SEO\Model\SEOAwareInterface::getMetaTitle()butCoreShop\Component\SEO\Model\SEOMetadataInterface::setTitle()always requires a string. This PR therefore adds a simple guard