Skip to content

Conversation

nicolasgarnil
Copy link
Contributor

@nicolasgarnil nicolasgarnil commented Aug 1, 2022

Description

PR adds support for the following statements:

  • CREATE PROCEDURE
  • DROP PROCEDURE
  • ALTER PROCEDURE

They are supported by all current dialects except for sqlite.

PR also adds a new dialect for BigQuery.

@nicolasgarnil nicolasgarnil marked this pull request as draft August 1, 2022 12:38
@nicolasgarnil nicolasgarnil changed the title Add BigQuery dialect Add BigQuery dialect and support for CREATE PROCEDURE Aug 1, 2022
src/parser.ts Outdated
case 'DECLARE':
case 'BEGIN':
if (options.dialect === 'oracle') {
if (['oracle', 'bigquery'].includes(options.dialect)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolasgarnil nicolasgarnil changed the title Add BigQuery dialect and support for CREATE PROCEDURE Add support for CREATE/DROP/ALTER PROCEDURE statements Aug 2, 2022
@MasterOdin MasterOdin marked this pull request as ready for review August 5, 2022 15:21
@MasterOdin MasterOdin merged commit 3776072 into coresql:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants