Fix identifying transaction statements #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes identifying
BEGIN TRANSACTION
statements. A number of SQL dialects (e.g. bigquery, sqlite) useBEGIN
both as a block opener, and as keyword right beforeTRANSACTION
to start a transaction (or in the case of sqlite, there's also three types of transactions one can use, see docs). As such, we now pass in thenextToken
when parsing in addition to the current token, allowing us to peek ahead one and see ifBEGIN
acts as a block opener, or to begin a transaction.I debated on making
BEGIN
check only for those dialects that use this explicitly, but decided against it and to make it generic in that there's probably no client that hasBEGIN TRANSACTION
and expects that to be operating in block mode as a fully working query.