Fix parsing bigquery control structures #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR improves parsing BigQuery control structures so that they're fully detected as their own potential standalone statements. Unlike Oracle, BigQuery's procedural language can be used without first using
DECLAREorSETorBEGINand can be completely standalone, and so we need to be able to detect that these are separate statements, and not part of a largerANON_BLOCKlike Oracle.BEGINthough for BigQuery can start an anon_block if it's the first word, and not followed by"TRANSACTION"which gives similar behavior as Oracle for that.See
CASEorFORin the below examples as statements that are completely standalone. The other loop structures probably expect aDECLAREorSETbefore it, but there's no guarantee.