-
Notifications
You must be signed in to change notification settings - Fork 10
Add SHOW statements for generic/mysql to parser #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHOW statements for generic/mysql to parser #68
Conversation
@MasterOdin these blocking changes, or can be merged? |
@wmontgomery if we're adding show support can we add all of them? https://dev.mysql.com/doc/refman/8.0/en/show.html Let's include this URL in a comment too |
Sorry for the delay here. It finally snowed in VT, and I've spent most of the last number of days either skiing, working my regular job, or being dead tired and sleeping. I hope to get to this at some point this week. |
had to add Profile as a keyword as part of one of the tests as it is a keyword now
@MasterOdin lgtm |
If you want to change to 'LISTING' once merged, that's fine by me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone and made all the SHOW
queries return as listing as that's what the DBs return the data as, and that there's an equivalent SELECT
query that you could run for a number of the shows, and it feels weird to have one be an INFORMATION
and one a LISTING
. Can revisit this if there's something specific someone wants to do with INFORMATION
on these, but so far doesn't sound like there is one.
Thanks for the contribution @wmontgomery! |
for #67