Skip to content

Conversation

wmontgomery
Copy link
Contributor

for #67

@rathboma
Copy link
Contributor

@MasterOdin these blocking changes, or can be merged?

@rathboma
Copy link
Contributor

@wmontgomery if we're adding show support can we add all of them?

https://dev.mysql.com/doc/refman/8.0/en/show.html

Let's include this URL in a comment too

@MasterOdin
Copy link
Member

Sorry for the delay here. It finally snowed in VT, and I've spent most of the last number of days either skiing, working my regular job, or being dead tired and sleeping. I hope to get to this at some point this week.

had to add Profile as a keyword as part of one of the tests as it is a keyword now
@rathboma
Copy link
Contributor

@MasterOdin lgtm

@rathboma
Copy link
Contributor

rathboma commented Jan 24, 2023

If you want to change to 'LISTING' once merged, that's fine by me

@MasterOdin MasterOdin changed the title feat(parser): add SHOW statements for mysql to parser Add SHOW statements for generic/mysql to parser Feb 6, 2023
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone and made all the SHOW queries return as listing as that's what the DBs return the data as, and that there's an equivalent SELECT query that you could run for a number of the shows, and it feels weird to have one be an INFORMATION and one a LISTING. Can revisit this if there's something specific someone wants to do with INFORMATION on these, but so far doesn't sound like there is one.

@MasterOdin
Copy link
Member

Thanks for the contribution @wmontgomery!

@MasterOdin MasterOdin merged commit 016baa7 into coresql:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants