Skip to content

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Aug 18, 2023

This is an attempt to improve tokenizing parameters in mssql where there are trailing non-alphanumerics like:

SELECT * FROM Persons WHERE id IN (:foo, :bar);

This should parse :foo and :bar instead of :foo, and :bar);.

Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@MasterOdin MasterOdin changed the title Fix trailing non-alphanumerics in mssql parameters Fix parsing trailing non-alphanumerics in mssql parameters Oct 4, 2023
@MasterOdin MasterOdin merged commit 58e526d into coresql:main Oct 4, 2023
@rathboma
Copy link
Contributor

rathboma commented Dec 4, 2023

@MasterOdin any chance you can push a bug fix release so we can also fix this bug in BKS?

@MasterOdin
Copy link
Member

@rathboma This has been included in the 2.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants