Skip to content

feat: add backdrop static option support to Offcanvas #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

feat: add backdrop static option support to Offcanvas #338

merged 2 commits into from
Jan 27, 2023

Conversation

korhanozbek44
Copy link
Contributor

Fixes #336
Added backdrop static option support to Offcanvas.

@korhanozbek44
Copy link
Contributor Author

@mrholek it took a long time

@mrholek
Copy link
Member

mrholek commented Jan 27, 2023

I had to make small improvements in the prop type should be backdrop?: boolean | 'static' instead backdrop?: boolean | string

@mrholek mrholek merged commit cbd4ef2 into coreui:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrholek mrholek mrholek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add backdrop option to 'static'
2 participants
@korhanozbek44 @mrholek