create team member component and integrate into about container #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvidsilva
reviewed
Mar 4, 2018
src/containers/about/index.js
Outdated
| The White House, Office of Science and Technology Policy, TEDx Speaker." | ||
| image = {sydneyImg} | ||
| link ={[{href: 'https://twitter.com/sydneylai', className: 'mg-circle'}]} | ||
| /> |
There was a problem hiding this comment.
The class name here should be, icon-s-twitter
dvidsilva
requested changes
Mar 4, 2018
dvidsilva
requested changes
Mar 4, 2018
src/containers/about/index.js
Outdated
| development @Techstars, @US Dept of Commerce, LGBT Technology Leader by | ||
| The White House, Office of Science and Technology Policy, TEDx Speaker." | ||
| image = {sydneyImg} | ||
| link ={[{href: 'https://twitter.com/sydneylai', className: 'mg-circle'}]} |
There was a problem hiding this comment.
The name of the property is links, not link
src/containers/about/index.js
Outdated
| Developer Bootcamp founder, @ Diamond, Techqueria, | ||
| Doctor on Demand, AngelHack, 40 Under 40: Tech Diversity – Silicon Valley." | ||
| image = {davidImg} | ||
| link={[{href: 'https://twitter.com/dvidsilva', className: 'con-s-twitter'}]} |
There was a problem hiding this comment.
same, The name of the property is links, not link
src/containers/about/index.js
Outdated
| title="Web Developer" | ||
| description="Web Developer who values building bridges between cultures and people, creating beautiful and meaningful things, and connecting people to resources that enrich their lives." | ||
| image = {tereImg} | ||
| link={[{href: 'https://www.linkedin.com/in/tere-gallarreta/', className: 'icon-linkedin'}]} |
There was a problem hiding this comment.
same, The name of the property is links, not link
src/containers/about/index.js
Outdated
| name="Corginson" | ||
| title="Chief Happiness Officer" | ||
| image= {corgiImg} | ||
| link={[{href: 'https://twitter.com/codecorgi', className: 'icon-s-twitter'}]} |
There was a problem hiding this comment.
same, The name of the property is links, not link
dvidsilva
force-pushed
the
feature/114-team-member
branch
from
0571b33 to
6c1a740
Compare
dvidsilva
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.