Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve travis configuration #34

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

corneliusweig
Copy link
Owner

  • upgrade to go 1.13
  • set GOPROXY env var
  • configure github releases on tags

- upgrade to go 1.13
- set GOPROXY env var
- configure github releases on tags
@corneliusweig corneliusweig merged commit 4b4a3eb into master Nov 15, 2019
@corneliusweig corneliusweig deleted the w/update-travis-config branch November 15, 2019 11:44
- GO111MODULE=on
- GOPROXY=https://proxy.golang.org

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing by 😉

isn't it default? why is it needed?

Copy link
Owner Author

@corneliusweig corneliusweig Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the default? I'm not sure.

Didn't really find a conclusive statement here https://github.com/golang/go/wiki/Modules

Copy link

@ferhatelmas ferhatelmas Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GOPROXY environment variable may now be set to a comma-separated list of proxy URLs or the special token direct, and its default value is now https://proxy.golang.org,direct

from release notes of 1.13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. I also found something here https://arslan.io/2019/08/02/why-you-should-use-a-go-module-proxy/

Guess I will remove it then :)
Thanks for spotting this!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to be helpful how minor it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants