Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize MiddlewareAuthentication for required endpoints #811

Merged
merged 13 commits into from
Jun 27, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented Jun 1, 2022

  • Create reusable permissions component for assets
  • add endpoint to get patient connected to asset /api/v1/consultation/patient_from_asset/
  • Write Tests

closes #671

@sainak sainak requested a review from vigneshhari June 4, 2022 11:36
care/facility/api/viewsets/mixins/access.py Outdated Show resolved Hide resolved
care/facility/models/daily_round.py Outdated Show resolved Hide resolved
@vigneshhari
Copy link
Member

We also need an endpoint that returns the current patient/consultation, only accessible by an asset, the data should be of the patient that is connected to the asset via a bed. Only the external_id needs to be returned

@sainak sainak requested a review from vigneshhari June 16, 2022 10:40
@gitguardian
Copy link

gitguardian bot commented Jun 23, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key fb9749b config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

2 similar comments
@gitguardian
Copy link

gitguardian bot commented Jun 23, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key fb9749b config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gitguardian
Copy link

gitguardian bot commented Jun 23, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
196640 Generic Private Key fb9749b config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gigincg
Copy link
Member

gigincg commented Jun 27, 2022

Solves #658

@sainak sainak requested a review from vigneshhari June 27, 2022 05:18
@vigneshhari vigneshhari marked this pull request as ready for review June 27, 2022 20:08
@vigneshhari vigneshhari requested a review from a team as a code owner June 27, 2022 20:08
@vigneshhari
Copy link
Member

Move tests to a different PR.

Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without testing.

@vigneshhari vigneshhari merged commit 6015e80 into master Jun 27, 2022
@sainak sainak deleted the sainak/feat/automated-daily-rounds branch September 6, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily Rounds API for Middleware
3 participants