Command line options clean up #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmccutchen-cci
changed the title
kyleheadley
approved these changes
Aug 30, 2021
mattmccutchen-cci
requested changes
Aug 30, 2021
john-h-kastner
added a commit
that referenced
this pull request
Oct 25, 2021
This is a follow up PR from #692 that moves all command line options into the _3COptions structure, moves all of 3C's command line options into the same category so that all options are shown by -help (fixes #393), and reformats some of the code around creating command line options. It also removes the the option -enable-itypeprop which was not referenced anywhere in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used the
_3COptionsstructure to store command line options immediately after they were parsed, but later copied the option value out of this structure and into global variables to use in the rest of the program. This pull request deletes the global variables, and replaces them with a global_3COptionsstructure.