Support All Asset Types for Media Widget #437
Conversation
…set types, not just images
| @@ -6,7 +6,7 @@ | |||
| = cell('index/content_item', nil, { cells: column[:cells], content_item: content_item }).(:column) | |||
| - if context[:popup] | |||
| %td{ class: 'mdl-data-table__cell--non-numeric' } | |||
| %a{ href: "#", data: { id: content_item.id, title: content_item_title(content_item), thumb: content_item_thumb_url(content_item), src: content_item_asset_url(content_item), alt: content_item_asset_alt_text(content_item) }, class: "media-select--#{context[:popup]} mdl-button mdl-js-button mdl-button--icon" } | |||
| %a{ href: "#", data: { id: content_item.id, title: content_item_title(content_item), thumb: content_item_thumb_url(content_item), url: content_item_asset_url(content_item), alt: content_item_asset_alt_text(content_item), asset_type: content_item_asset_type(content_item) }, class: "media-select--#{context[:popup]} mdl-button mdl-js-button mdl-button--icon" } | |||
There was a problem hiding this comment.
I assume I'm over looking it, but where does the URL get fed into a src attribute?
There was a problem hiding this comment.
This happens in cortex-plugins-core, here: https://github.com/cortex-cms/cortex-plugins-core/pull/39/files#diff-f5165bb3219f906c9714100622beb28eR18
The way things are happening right now are needlessly complex. In our React rebuild, this should simplify significantly.
There was a problem hiding this comment.
Yep I just got to that part!
There was a problem hiding this comment.
So if someone embeds a doc file, how would that be presented online when the blog post is viewed?
There was a problem hiding this comment.
Ok, if it was a PDF would they want it to be a PDF view?
There was a problem hiding this comment.
Nah - almost always, they just include PDFs as links. If they want a PDF view, they'll come to us with that requirement. Keep in mind this is for a blog - I can't think of many blogs that embed PDFs in their copy
There was a problem hiding this comment.
AKA: Usually PDFs are for 'take home' materials - things you want the user to download so they can view later or print to share with others
Add supporting infrastructure to allow Media Widget to support all asset types, not just images