Fog of War and Activity Settings Fixes #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Manager to allow casting boxes to facilitate it, modified base scanner, Ronin scrambler for aesthetic (placeholder). Modified certain activity setups to avoid assertion failures, ignoring activity settings, allowing settings tinkering when they don't (and shouldn't) do anything, and a certain strange fog set up in Brain Versus Brain.
… dial in Decision Day being enabled when it does nothing, made scrambler less bad, just don't throw 1000 of them in a frame.
Causeless
reviewed
May 28, 2024
|
Looks great! Few questions ad comments |
|
Awesome, thanks for the quick response to my questions - I'm happy with all of this. You mentioned you have some more commits coming, so let me know when this is ready and I'll merge (otherwise you can set this to draft until you're ready) |
Causeless
previously approved these changes
May 28, 2024
|
Oh, please update changelog if you can, too! |
…CastUnseenBox, further refined mission-activity/generic activity settings, moved and "standardized" mission-type activity fog handling, further normalized and fixed generic activity fog handling.
…th sum penetration rays, made metagame use fine fog.
…rposes, removed CastUnseenBox and instead changed the contents of CastUnseenRay, neglected changelog. This will be repaired, currently stress testing.
…rdized 4x4 fog in all vanilla scenarios and conquest, fixed changelog.
Causeless
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fog resolution increased dramatically, reveal by sight, scrambler rework, scanner rework, activity settings no longer ignored, out of place activity settings no longer enabled.