Support defaults on env vars #57
Merged
+35
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnburke
force-pushed
the
shawn/default-vars
branch
from
2924adf to
2f21d69
Compare
shawnburke
force-pushed
the
shawn/default-vars
branch
from
2f21d69 to
7787851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at change https://github.com/cortexapps/axon/pull/55/files, which introduces a way to make scaffolding work but is a breaking change at it requires
GITHUB_USERNAMEandGITHUBvars to be added.rather than making this a breaking change i think it's useful to:
${GITHUB:github.com}GITHUB,GITHUB_USERNAME) if scaffolding is need.This change adds an update to the pre-processor to find defaulted values and replace them before the accept file is processed.