Skip to content

Search all environments for AWS credential defaults #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2020
Merged

Search all environments for AWS credential defaults #1044

merged 4 commits into from
May 9, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented May 8, 2020

closes #726

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu requested a review from vishalbollu May 8, 2020 02:57
vishalbollu
vishalbollu approved these changes May 8, 2020
View reviewed changes
@deliahu deliahu merged commit a40b678 into master May 9, 2020
@deliahu deliahu deleted the env-aws-defaults branch May 9, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use default environment keys as default in cortex configure prompts for new environments
2 participants
@deliahu @vishalbollu