Skip to content

Add more widgets to the CloudWatch Dashboard #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 22, 2020
Merged

Add more widgets to the CloudWatch Dashboard #1181

merged 25 commits into from
Jul 22, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jun 29, 2020 •
edited
Loading

This PR adds 2 more widgets to the CloudWatch Dashboard of each API:

  • avg in-flight requests per replica - to show the average load on each API replica.
  • active replicas - to show how many online replicas each API has.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian added enhancement New feature or request refactor Improve code quality labels Jun 29, 2020
@RobertLucian RobertLucian requested a review from deliahu June 29, 2020 00:29
deliahu
deliahu reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for adding the new plots! I'm glad we already had the necessary metrics ready to go.

@RobertLucian RobertLucian requested a review from deliahu July 1, 2020 17:26
deliahu
deliahu reviewed Jul 1, 2020
View reviewed changes
@RobertLucian RobertLucian requested a review from deliahu July 2, 2020 15:25
deliahu
deliahu approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobertLucian RobertLucian merged commit bcd0242 into master Jul 22, 2020
@RobertLucian RobertLucian deleted the feature/add-dashboard-metrics branch July 22, 2020 15:59
@deliahu deliahu added this to the v0.19 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor Improve code quality
Projects
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu