Skip to content

Improve CNI supported instances check #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2020
Merged

Improve CNI supported instances check #1332

merged 4 commits into from
Sep 11, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Sep 7, 2020 •
edited
Loading

closes #1331, closes #809

Note that the compatible instance types for the default CNI version has been uploaded to https://cortex-public.s3-us-west-2.amazonaws.com/cli-assets/cni_supported_instances.txt, and should be periodically updated to reflect reality.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu requested a review from vishalbollu September 7, 2020 03:16
vishalbollu
vishalbollu approved these changes Sep 11, 2020
View reviewed changes
@deliahu deliahu merged commit b83e0d5 into master Sep 11, 2020
@deliahu deliahu deleted the cni-supported-instances branch September 11, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CNI supported instances check Support c6g and r6g instances
2 participants
@deliahu @vishalbollu