Skip to content

Set default api gateway value to none if disabled cluster-wide #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 10, 2020
Merged

Set default api gateway value to none if disabled cluster-wide #1337

merged 5 commits into from
Sep 10, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Sep 7, 2020 •
edited
Loading

closes #1336

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@deliahu deliahu requested a review from vishalbollu September 7, 2020 04:01
vishalbollu
vishalbollu approved these changes Sep 10, 2020
View reviewed changes
Base automatically changed from rename-cluster-api-gateway-config to master September 10, 2020 22:56
@deliahu deliahu merged commit f7b254c into master Sep 10, 2020
@deliahu deliahu deleted the update-api-gateway-default branch September 10, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default api gateway value to none if disabled cluster-wide
2 participants
@deliahu @vishalbollu