Skip to content

Display environment list output in json #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2020
Merged

Display environment list output in json #1444

merged 3 commits into from
Oct 15, 2020

Conversation

vishalbollu
Copy link
Contributor

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested a review from deliahu October 14, 2020 16:57
deliahu
deliahu approved these changes Oct 14, 2020
View reviewed changes
cli/cmd/env.go
}

if _flagOutput == flags.JSONOutputType {
bytes, err := libjson.Marshal(cliConfig.Environments)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use MarshalIndent() here to make it look nicer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, for now -o json will not pretty print json.

@vishalbollu vishalbollu merged commit 443ed02 into master Oct 15, 2020
@vishalbollu vishalbollu deleted the env-list-json-output branch October 15, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu